lib: fix URL constructor #1665
Closed
lib: fix URL constructor #1665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return from `require('url')` is not the URL constructor, that is
exported as `url.URL`. The constructor is generally available as a
global, so this pattern isn't 100% necessary, but this is the best
way to do it based on existing patterns in npm
Refs: nodejs/node#34738
Fixes: npm#1658
MylesBorins
force-pushed
the
fix-URL-constructor
branch
from
39d5559 to
1daf7ae
Compare
|
dupe of #1661 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return from
require('url')is not the URL constructor, that isexported as
url.URL. The constructor is generally available as aglobal, so this pattern isn't 100% necessary, but this is the best
way to do it based on existing patterns in npm
Refs: nodejs/node#34738